Adding functions to allow hubot to create rooms and invite users to rooms#72
Open
pseudomorph wants to merge 1 commit intoxmppjs:masterfrom
Open
Adding functions to allow hubot to create rooms and invite users to rooms#72pseudomorph wants to merge 1 commit intoxmppjs:masterfrom
pseudomorph wants to merge 1 commit intoxmppjs:masterfrom
Conversation
Contributor
|
It would be good to have a test case for this, so it doesn't get broken in any future refactoring/work. |
|
This would be a darn nifty feature to have. Any chance the conflicts can be corrected and this feature documented? |
Contributor
|
@krutaw I probably won't be able to find the time to do that, but if you have the time I'm happy to merge this kind of change. |
|
@markstory It's not a lack of time on my part, but a lack of understanding on how to write the test case you mentioned earlier in the thread as well as how to identify the conflicts that currently exist. |
Contributor
|
Generally the tests would be asserting that the XML being send to the jabber server is correctly formed. You can likely use something like the ping/pong test as an example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using this to make dynamic room creation/interaction for our workflow.