stream-management: Fix failed resumption #1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not the function named failed
singpolyma
force-pushed
the
element-is-failed
branch
from
3b8cc3a to
78ced72
Compare
sonnyp
reviewed
Feb 19, 2025
| ); | ||
|
|
||
| expect(entity.streamManagement.outbound).toBe(45); | ||
| expect(entity.streamManagement.outbound).toBe(0); |
Member
There was a problem hiding this comment.
can you help me understand this change and why that expectation is correct ?
Contributor
Author
There was a problem hiding this comment.
If resume fails then we should not keep the previous outbound count from previous session, since we did not resume it, but rather we are starting a new session counting at zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not the function named failed