Fix flapping test - #1097
Conversation
Race condition between the timers and close (which happens first) vs disconnect (which happens after).
| } | ||
|
|
||
| entity.on("disconnect", () => { | ||
| entity.on("close", () => { |
There was a problem hiding this comment.
disconnect looks correct logicially to me here.
Please explain why this makes more sense than changing the test.
There was a problem hiding this comment.
After the stream has closed no more stanzas can be sent. If the timeout fires after close but before disconnect, it will try to send and that is what caused the problem. Now we correctly stop the timers at close so they cannot fire on a closed stream.
There was a problem hiding this comment.
While investigating I realized there are 2 separate problems
First one is write after end
stream management shouldn't throw when attemtping to send stanzas if the stream or socket is closed
Fixed by #1099
I'll get back to the second one later.
There was a problem hiding this comment.
yes this is the one fixed by this PR. I see from the current CI results there is another one
I'm a bit confused by this second one. It seems to be triggered by data coming in when there is no parser? But I'm not sure how that's possible. Maybe a race condition creating the parser after connect?
2 participants
Race condition between the timers and close (which happens first) vs disconnect (which happens after).