Add docs about how to create a signer with a key pair#692
Open
Add docs about how to create a signer with a key pair#692
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
|
|
||
| - **EOAs on EVM chain**: Work automatically. Signature verification is purely cryptographic (secp256k1 ECDSA), so no configuration is needed. | ||
| - **SCWs on EVM chains**: Require adding the chain's RPC endpoint to the verifier config. See [Create a SCW signer](/chat-apps/core-messaging/create-a-signer#create-a-smart-contract-wallet-signer). | ||
| - **SCWs on EVM chains**: Require adding the chain's RPC endpoint to the verifier config. See [Create a SCW signer](/chat-apps/core-messaging/create-a-signer#from-a-smart-contract-wallet-scw). |
There was a problem hiding this comment.
🟡 Medium core-messaging/extend-id-model.md:12
Anchor #from-a-smart-contract-wallet-scw doesn't exist in the target file. Consider using #create-a-signer-from-a-scw to match the heading "Create a signer from a SCW".
Suggested change
| - **SCWs on EVM chains**: Require adding the chain's RPC endpoint to the verifier config. See [Create a SCW signer](/chat-apps/core-messaging/create-a-signer#from-a-smart-contract-wallet-scw). | |
| - **SCWs on EVM chains**: Require adding the chain's RPC endpoint to the verifier config. See [Create a SCW signer](/chat-apps/core-messaging/create-a-signer#create-a-signer-from-a-scw). |
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file docs/pages/chat-apps/core-messaging/extend-id-model.md around line 12:
Anchor `#from-a-smart-contract-wallet-scw` doesn't exist in the target file. Consider using `#create-a-signer-from-a-scw` to match the heading "Create a signer from a SCW".
|
|
||
| ```ts | ||
| import { createPublicClient, http } from 'viem'; | ||
| import { mainnet } from 'viem/chains'; |
There was a problem hiding this comment.
🟡 Medium core-messaging/create-a-signer.mdx:219
The chain: mainnet doesn't match the Base RPC URL. Consider using base from viem/chains instead.
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file docs/pages/chat-apps/core-messaging/create-a-signer.mdx around line 219:
The `chain: mainnet` doesn't match the Base RPC URL. Consider using `base` from `viem/chains` instead.
| const code = await client.getCode({ address }); | ||
|
|
||
| // EOAs have no bytecode, while smart contracts do. | ||
| if (code === undefined) { |
There was a problem hiding this comment.
🟡 Medium core-messaging/create-a-signer.mdx:242
viem's getCode returns '0x' for EOAs, not undefined. Consider checking if (!code || code === '0x') instead.
Suggested change
| if (code === undefined) { | |
| if (!code || code === '0x') { |
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file docs/pages/chat-apps/core-messaging/create-a-signer.mdx around line 242:
viem's `getCode` returns `'0x'` for EOAs, not `undefined`. Consider checking `if (!code || code === '0x')` instead.
bennycode
reviewed
Feb 25, 2026
| | Security model | Single key | Policy-based, multi-layer security | | ||
| ## Create a signer from a key pair | ||
|
|
||
| ## How do I know if I have a SCW? |
Member
There was a problem hiding this comment.
Can we preserve this content for a "XMTP for Web3" section? I got these SCW questions asked multiple times already.
jhaaaa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is phase 1 of updating docs to reframe web3/crypto
Document creating a signer from a key pair
📊 Macroscope summarized f93f7ea. 5 files reviewed, 3 issues evaluated, 0 issues filtered, 3 comments posted
🗂️ Filtered Issues