Skip to content

fix(xmtp_api_d14n): close two bidi ledger loss holes under overlapping catch-up waves #3852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tylerhawkes wants to merge 1 commit into
base: main
Choose a base branch
from
+745 −62
Open

fix(xmtp_api_d14n): close two bidi ledger loss holes under overlapping catch-up waves #3852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions crates/xmtp_api_d14n/src/queries/bidi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ use std::time::Duration;
use futures::StreamExt;
use futures::stream::BoxStream;
use tokio::sync::{mpsc, oneshot};
use xmtp_common::{AbortHandle, StreamHandle};
use xmtp_common::{AbortHandle, MaybeSend, MaybeSync, StreamHandle};
use xmtp_proto::types::{Topic, TopicKind};

/// Wire-outbound depth. The actor is the sole writer; a transport that stops
Expand Down Expand Up @@ -94,10 +94,13 @@ pub trait BidiBinding: Send + 'static {
type Response: Send + 'static;
/// The backend's `Mutate` payload (v3: single `id_cursor`; d14n: vector cursor).
type Mutate: Send;
/// Consumer-facing group message (v3: raw proto; d14n: unified, post-extract).
type GroupMessage: Send;
/// Consumer-facing welcome message (v3: raw proto; d14n: unified, post-extract).
type WelcomeMessage: Send;
/// Consumer-facing group message (v3: raw proto; d14n: unified,
/// post-extract). `MaybeSync` because the transport ledger shares
/// withheld frames between holders via `Arc` inside its actor.
type GroupMessage: MaybeSend + MaybeSync;
/// Consumer-facing welcome message (v3: raw proto; d14n: unified,
/// post-extract). `MaybeSync` for the same reason as `GroupMessage`.
type WelcomeMessage: MaybeSend + MaybeSync;

/// Wrap a `Mutate` as an outbound request frame.
fn mutate_frame(mutate: Self::Mutate) -> Self::Request;
Expand Down
Loading
Loading