-
Notifications
You must be signed in to change notification settings - Fork 7
Mc/update kotlin gh action reverted #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Use ORG_GRADLE_PROJECT_ env vars for Gradle property injection - Update workflow to use sonatypeUsername/sonatypePassword - Update build.gradle to use project.findProperty() instead of System.getenv() - Add snapshotRepositoryUrl to nexus publishing config - Add version validation and better error logging - Add conditional signing to support local builds This fixes the 401 Unauthorized error when publishing to Sonatype. The gradle-nexus-publish-plugin requires credentials as Gradle project properties, not custom environment variables. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
neekolas
approved these changes
Oct 24, 2025
This reverts commit 3a2ef4b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update release workflow to run Kotlin job on 'mc/update-kotlin-gh-action-reverted', set up Java 11, validate Gradle wrappers with v4, and use MAVEN_* env vars for publishing
Adjust GitHub Actions release workflow to add a testing branch trigger, enable npm cache and pass
NPM_TOKEN, set explicit Kotlin job permissions, add Java 11 setup, upgrade toactions/setup-gradle@v4with wrapper validation, fail if no git tags when computingVERSION, and switch publishing credentials toMAVEN_USERNAME,MAVEN_PASSWORD,MAVEN_PROFILE_ID. Update Sonatype config to read MAVEN_* from env. Harden the Kotlin protoc generator script withset -euand deterministic plugin resolution.📍Where to Start
Start with the workflow changes in release.yml, focusing on the Gradle setup, tag/version computation, and Maven credential updates.
Changes since #306 opened
/opt/protoc-pluginsdirectory and consolidated Docker build steps [b212bb8]--no-daemonflag to Gradle publish command in release workflow [95890b3]nexusPublishing.repositories.sonatypeconfiguration to add snapshot repository URL and refactor credential handling [edbb611]nexusPublishingsettings [edbb611]kotlinjob unconditional [fc8f7ab]Macroscope summarized 0e33702.