Add SubscribeAllEnvelopes endpoint to the Replication API#322
Merged
Conversation
Maelkum
commented
Mar 4, 2026
| }; | ||
| } | ||
|
|
||
| rpc SubscribeAllEnvelopes(SubscribeAllEnvelopesRequest) returns (stream SubscribeEnvelopesResponse) { |
Contributor
Author
There was a problem hiding this comment.
Return type is reused - shared with the SubscribeEnvelopes endpoint, since they return the same thing
mkysel
approved these changes
Mar 4, 2026
Collaborator
|
I do not believe subscribe all needs a cursor. We don't provide it in the V3 version and it is very expensive to deliver on. If someone provides a cursor of 0 we are going to try and send them terrabytes of messages immediately. |
Contributor
Author
Makes sense, I created an issue to change that in a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new endpoint to the Replication API specification, allowing subscription to all envelopes, with a cursor to optionally specify starting point.
This is a somewhat distinct version of
SubscribeEnvelopes, which mandates that either topics or originators are specified in the query filter.This endpoint will be primarily (only) used by the notification server, and will have separate authorization and rate limit settings (details TBD).
Part of work on xmtp/example-notification-server-go#61
Note
Add
SubscribeAllEnvelopesRPC endpoint to the Replication APIAdds a new
SubscribeAllEnvelopesstreaming RPC to theReplicationApiservice in message_api.proto, exposed asPOST /mls/v2/subscribe-all-envelopes. The newSubscribeAllEnvelopesRequestmessage accepts an optionallast_seencursor to support resumable streaming, and returns a stream ofSubscribeEnvelopesResponsemessages.Macroscope summarized 1565c0e.