Some logging level changes #1521
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neekolas
reviewed
Jan 9, 2026
| "inserting message from contract", | ||
| utils.TopicField(topicStruct.String()), | ||
| ) | ||
| if s.logger.Core().Enabled(zap.DebugLevel) { |
Contributor
There was a problem hiding this comment.
Does this functionally do anything, other than save a tiny bit of execution on generating the topicField?
Collaborator
Author
There was a problem hiding this comment.
nope. just a tiny optimization. Might be a good pattern to get in the habit of using.
Collaborator
There was a problem hiding this comment.
Specially useful when using zap.Any(), because avoids using reflection outside Debug loglevel.
fbac
approved these changes
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust logging levels in
contracts.GroupMessageStorer.StoreLog,contracts.IdentityUpdateStorer.StoreLog,common.IndexLogs, andrpc_streamer.RPCLogStreamer.watchContract, adding 5-minute Info progress logs and moving termination logs to InfoRaises operational log levels to Info/Warn, adds periodic 5-minute Info progress logs for the latest block, and guards Debug logs behind a
zap.DebugLevelcheck.📍Where to Start
Start with
common.IndexLogsin log_handler.go.Macroscope summarized 5402e97.