Skip to content

Release 1.1.0#521

Merged
yewreeka merged 1 commit into
devfrom
release/1.1.0
Feb 25, 2026
Merged

Release 1.1.0#521
yewreeka merged 1 commit into
devfrom
release/1.1.0

Conversation

@yewreeka

@yewreeka yewreeka commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Bumps version to 1.1.0 for release.

Changes

  • Updates MARKETING_VERSION to 1.1.0 in Xcode project

After Merge

When this PR is merged, GitHub Actions will automatically:

  1. Create tag 1.1.0
  2. Delete the release branch
  3. Trigger the auto-release workflow to create a GitHub Release

Note

Update app CFBundleShortVersionString by setting MARKETING_VERSION to 1.1.0 across Xcode build configurations for Release 1.1.0 in project.pbxproj

Set MARKETING_VERSION from 1.0.6 to 1.1.0 in Xcode build settings, affecting the reported app version (CFBundleShortVersionString).

📍Where to Start

Start with the build settings diffs in project.pbxproj, focusing on MARKETING_VERSION entries.

Macroscope summarized 488d509.

@claude

claude Bot commented Feb 25, 2026

Copy link
Copy Markdown

Claude finished @yewreeka's task —— View job


PR Review: Release 1.1.0

Tasks

  • Read changed file (project.pbxproj)
  • Analyze version bump changes
  • Provide comprehensive review feedback

Review Feedback

Summary

This PR correctly bumps the marketing version from 1.0.6 to 1.1.0 across all build configurations and targets.

Code Quality ✅

  • Clean version bump: All 24 occurrences of MARKETING_VERSION have been updated consistently from 1.0.6 to 1.1.0
  • Comprehensive coverage: Version updated across all targets including:
    • Main app configurations (Dev, Local, Production)
    • KeychainIdentityStoreExample
    • Tests
    • App Clip
    • Notification Service Extension

Potential Issues ✅

  • No issues found. The changes are mechanical and correct.

Performance ✅

  • No performance impact. This is a metadata-only change.

Security ✅

  • No security concerns. Version bumps do not introduce security risks.

Test Coverage ⚠️

  • Minor observation: While this is a low-risk change, the PR doesn't include verification that the app builds successfully with the new version number. Consider running a build validation before merging to ensure no unexpected issues.
  • No test changes needed for version bumps.

Additional Notes

  • The automation plan (tag creation, branch deletion, release workflow) mentioned in the PR description is appropriate for a release PR.
  • Ensure the corresponding git tag 1.1.0 matches this version exactly.

Recommendation

Approve - This is a straightforward, correctly implemented version bump with no code quality, security, or functional concerns.


@yewreeka yewreeka merged commit e52471e into dev Feb 25, 2026
7 checks passed
@yewreeka yewreeka deleted the release/1.1.0 branch February 25, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant