Sync ERC-8262.md with upstream + keep F-2/F-3 deltas#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repo's
ERC-8262.mdhad fallen 187 lines behind the upstream../ERCs/ERCS/erc-8262.mdsubmitted to ethereum/ERCs#1747. This PR brings the two into sync and preserves the F-2/F-3 normative deltas just landed in #14.Sections pulled from upstream
F-2 / F-3 deltas kept from #14
pattern.settlement_rootMUST mark + canonical computationF-1 (UAE) was already in upstream. F-4 (proofHash forward-ref) was already in upstream as the
-- see Proof Hash Computationcomment.After this lands
Both files are byte-equal except for the three F-2 / F-3 deltas this repo carries. The companion PR (xochi-fi/ERCs side) pushes the same deltas to upstream; after that PR, the files match exactly.
Manual testing
python3 scripts/eip-interface-drift.py-- clean (interface signatures unchanged)forge fmt --check-- cleanforge build-- clean (no Solidity touched)