ERC-8262: jurisdiction policy table + tighter settlement_root#1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two pre-audit normative fixes for the in-flight ERC-8262 submission (ethereum#1747). Both land in the reference implementation repo as well; this PR brings the fork branch in sync.
F-2 -- Jurisdiction Policy as normative table
The current draft mentions
requireSignedSignalsandminMultiProviderThresholdonly as parenthetical asides ("e.g. US BSA, Singapore, UAE VARA require M >= 2"). A reader implementing from the spec alone could ship without the rejection logic.This PR adds a Jurisdiction Policy subsection right after the threshold table. It tabulates the canonical "Accepts unsigned" and "Min
threshold_m" values per jurisdiction with MUST language. Three scattered prose asides are replaced with "(see Jurisdiction Policy)" cross-refs.F-3 -- pattern.settlement_root binding strengthened to MUST
The Pattern proof bullet previously said consumers
SHOULD mark each consumed pattern proof to prevent reuse. With only the SettlementRegistry as a downstream consumer demonstrating this, a future consumer could silently accept a single PATTERN attestation as a standin for the binding it expects.This PR promotes
SHOULD marktoMUST markand adds the canonical computationkeccak256(abi.encode(uint8 subTradeCount, bytes32[] subProofHashes)) mod BN254_FR_MODULUS. The note also calls out that field width orabi.encodebyte layout drift produces a different root and the equality check rejects.Notes
-- see Proof Hash Computationcomment.After this lands, the fork branch and the reference implementation's
ERC-8262.mdare byte-equal.