Skip to content

Add no-duplicate-imports #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fregante wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add no-duplicate-imports #92

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e19856
Add `no-duplicate-imports`
fregante Aug 18, 2025
075e29f
Lint the linter
fregante Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@
'no-dupe-else-if': 'error',
'no-dupe-keys': 'error',
'no-duplicate-case': 'error',
'no-duplicate-imports': [
'error',
{
allowSeparateTypeImports: true,
Copy link
Member Author

@fregante fregante Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allows:

import type React from 'react';
import {useMemo} from 'react';

because nobody knows this:

import {useMemo, type default as React} from 'react';

},
],
'no-empty-character-class': 'error',
'no-empty': [
'error',
Expand Down Expand Up @@ -206,7 +212,7 @@
radix: 'error',

// Disabled for now as it causes too much churn
// TODO: Enable it in the future when I have time to deal with

Check warning on line 215 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 18 

Unexpected 'todo' comment: 'TODO: Enable it in the future when I...'

Check warning on line 215 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 20 

Unexpected 'todo' comment: 'TODO: Enable it in the future when I...'

Check warning on line 215 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 22 

Unexpected 'todo' comment: 'TODO: Enable it in the future when I...'

Check warning on line 215 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 22 

Unexpected 'todo' comment: 'TODO: Enable it in the future when I...'

Check warning on line 215 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 18 

Unexpected 'todo' comment: 'TODO: Enable it in the future when I...'

Check warning on line 215 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 20 

Unexpected 'todo' comment: 'TODO: Enable it in the future when I...'
// the churn and the rule is stable and has an autofixer.
// Still doesn't have a fixer as of ESLint 7.24.0.
// 'require-unicode-regexp': 'error',
Expand All @@ -226,7 +232,7 @@
{
globals: [
'event',
// TODO: Enable this in 2025.

Check warning on line 235 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 18 

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 235 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 20 

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 235 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 22 

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 235 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 22 

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 235 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 18 

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 235 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 20 

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'
// {
// name: 'Buffer',
// message: 'Use Uint8Array instead. See: https://sindresorhus.com/blog/goodbye-nodejs-buffer',
Expand Down Expand Up @@ -273,7 +279,7 @@
'sys',
'querystring',
'colors',
// TODO: Enable this in 2025.

Check warning on line 282 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 18 

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 282 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 20 

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 282 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 22 

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 282 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 22 

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 282 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 18 

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'

Check warning on line 282 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 20 

Unexpected 'todo' comment: 'TODO: Enable this in 2025.'
// {
// name: 'buffer',
// message: 'Use Uint8Array instead. See: https://sindresorhus.com/blog/goodbye-nodejs-buffer',
Expand Down Expand Up @@ -672,7 +678,7 @@
{
// `array` is disabled because it forces destructuring on
// stupid stuff like `foo.bar = process.argv[2];`
// TODO: Open ESLint issue about this

Check warning on line 681 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 18 

Unexpected 'todo' comment: 'TODO: Open ESLint issue about this'

Check warning on line 681 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 20 

Unexpected 'todo' comment: 'TODO: Open ESLint issue about this'

Check warning on line 681 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 22 

Unexpected 'todo' comment: 'TODO: Open ESLint issue about this'

Check warning on line 681 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 22 

Unexpected 'todo' comment: 'TODO: Open ESLint issue about this'

Check warning on line 681 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 18 

Unexpected 'todo' comment: 'TODO: Open ESLint issue about this'

Check warning on line 681 in index.js

View workflow job for this annotation

GitHub Actions / Node.js 20 

Unexpected 'todo' comment: 'TODO: Open ESLint issue about this'
VariableDeclarator: {
array: false,
object: true,
Expand Down