Ignore source map files while publishing#783
Merged
Merged
Conversation
Member
|
I agree, I don't think we should publish source maps files. The most common usage is the CLI, and source maps add a lot of weight to the package size. |
spence-s
approved these changes
Apr 4, 2025
Contributor
spence-s
left a comment
spence-s
left a comment
There was a problem hiding this comment.
Yep, agreed this is good. I like that this leaves them in the build as well and filters them at publish time, so test errors can be reported using source maps still.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please correct me if I'm wrong.
It looks like we only used those source map files for testing purposes. Maybe we could ignore them while publishing to npm.