Fix parent XO config resolution from nested package cwd#883
Open
sjh9714 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes XO config resolution when running from a nested package in a monorepo.
What changed
package.jsonXO config from a nested packagecwd.Why
Issue #733 reports that packages in a monorepo do not pick up the root XO config. The previous search stopped before reaching the monorepo root.
Testing
npm run buildnpm run test:setupnpx ava dist/test/resolve-config.test.jsnode dist/cli.js lib/resolve-config.ts test/resolve-config.test.tsgit diff --checkNote: I also checked
npm test; it currently stops at the lint step on both this branch andupstream/mainwith the same pre-existing@typescript-eslint/no-unnecessary-type-assertionreports inlib/utils.tsandlib/xo.ts.Fixes #733