Skip to content

Include opening and closing pipes in the table span #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

snnz
Copy link
Contributor

@snnz snnz commented Dec 18, 2024

Fixes #775

@xoofx
Copy link
Owner

xoofx commented Dec 18, 2024

Could you add a test for this one to validate the fix and prevent from a regression? If we want to rewrite the pipetable parser with a different (and simpler) strategy, more compatible with GitHub, it would help a lot.

@snnz
Copy link
Contributor Author

snnz commented Dec 18, 2024

I've made a test based on an existing one.

@xoofx xoofx merged commit a8de208 into xoofx:master Dec 18, 2024
1 check passed
@xoofx xoofx added the bug label Dec 18, 2024
@snnz snnz deleted the fix-pipetable-span branch December 19, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PipeTableParser strip opening and ending characters
2 participants