Skip to content

Fix errors in LinkHelper and LinkInlineParser. #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 27, 2024
Merged

Fix errors in LinkHelper and LinkInlineParser. #837

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c35f7ff
Fixed errors in LinkHelper and LinkInlineParser.
snnz Dec 21, 2024
90365bf
Update src/Markdig/Parsers/Inlines/LinkInlineParser.cs
snnz Dec 21, 2024
ad0770a
Update src/Markdig/Parsers/Inlines/LinkInlineParser.cs
snnz Dec 21, 2024
54783b8
Update src/Markdig/Parsers/Inlines/LinkInlineParser.cs
snnz Dec 21, 2024
7f604be
Update src/Markdig/Parsers/Inlines/LinkInlineParser.cs
snnz Dec 21, 2024
90bc15c
Update src/Markdig.Tests/TestPlayParser.cs
snnz Dec 21, 2024
ab8e85b
Remove additional condition, since a carriage return constitute a lin…
snnz Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/Markdig.Tests/TestLinkHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,14 @@ public void TestTitleMultiline()
Assert.AreEqual("this\ris\r\na\ntitle", title);
}

[Test]
public void TestTitleMultilineWithSpaceAndBackslash()
{
var text = new StringSlice("'a\n\\ \\\ntitle'");
Assert.True(LinkHelper.TryParseTitle(ref text, out string title, out _));
Assert.AreEqual("a\n\\ \\\ntitle", title);
}

[Test]
public void TestUrlAndTitle()
{
Expand Down Expand Up @@ -238,6 +246,13 @@ public void TestlLinkReferenceDefinitionSimple()

}

[Test]
public void TestlLinkReferenceDefinitionInvalid()
{
var text = new StringSlice("[foo]: /url (title) x\n");
Assert.False(LinkHelper.TryParseLinkReferenceDefinition(ref text, out _, out _, out _, out _, out _, out _));
}

[Test]
public void TestAutoLinkUrlSimple()
{
Expand Down
8 changes: 8 additions & 0 deletions src/Markdig.Tests/TestPlayParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,14 @@ public void TestLink()
Assert.AreEqual("/yoyo", link?.Url);
}

[Test]
public void TestLinkWithMultipleBackslashesInTitle()
{
var doc = Markdown.Parse(@"[link](/uri '\\\\127.0.0.1')");
var link = doc.Descendants<ParagraphBlock>().SelectMany(x => x.Inline.Descendants<LinkInline>()).FirstOrDefault();
Assert.AreEqual(@"\\127.0.0.1", link?.Title);
}

[Test]
public void TestListBug2()
{
Expand Down
Loading
Loading