fix: route SDK v1 requests through nginx#569
Open
AlexLiu190625 wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new '/v1/' location block in 'docker/nginx.conf' to proxy SDK API requests to the backend. The reviewer pointed out that this block unnecessarily includes WebSocket-specific headers (such as 'Upgrade' and 'Connection "upgrade"') for standard HTTP REST API endpoints, which can degrade performance and lead to socket exhaustion. A code suggestion was provided to remove these headers.
AlexLiu190625
force-pushed
the
fix/sdk-v1-nginx-routing
branch
from
d0ca7c5 to
bac4a0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/v1/SDK API requests through the Docker nginx frontend to the backend service.Why
The backend owns SDK v1 endpoints such as
/v1/meand/v1/chat/tasks*. Without an explicit nginxlocation /v1/, those requests fall through to the frontend catch-all route and return frontend 404 HTML instead of backend API responses.Validation
git diff --checkdocker/nginx.confnow has/v1/before the frontend/catch-all route.