Skip to content

implement support for st7735 display#2319

Open
dpeddi wants to merge 12 commits into
xoseperez:devfrom
dpeddi-iot:st7735
Open

implement support for st7735 display#2319
dpeddi wants to merge 12 commits into
xoseperez:devfrom
dpeddi-iot:st7735

Conversation

@dpeddi

@dpeddi dpeddi commented Aug 12, 2020

Copy link
Copy Markdown
Contributor

initial support for st7735 display

@dpeddi

dpeddi commented Aug 12, 2020

Copy link
Copy Markdown
Contributor Author

image
image
image
image

Comment thread code/espurna/thermostat.h Outdated
Comment thread code/espurna/thermostat.h Outdated
Comment thread code/platformio.ini
Comment thread code/espurna/main.cpp Outdated
Comment thread code/espurna/thermostat.cpp Outdated
Comment thread code/espurna/thermostat.cpp
Comment thread code/espurna/Roboto_Thin9pt8b.h
Comment thread code/espurna/thermostat.cpp Outdated
Comment thread code/espurna/thermostat.cpp Outdated
Comment thread code/espurna/thermostat.cpp Outdated
@dpeddi

dpeddi commented Aug 18, 2020

Copy link
Copy Markdown
Contributor Author

the original developer used ThingPulse/esp8266-oled-ssd1306, if someone who have ssd1306 would move to adafruit/Adafruit_SSD1306 probably there would be less ifdef.

Next step may be to create a display "class" to be referenced from espurna itself for ip address/ssid and/or relay status..

@mcspr

mcspr commented Aug 19, 2020

Copy link
Copy Markdown
Collaborator

the original developer used ThingPulse/esp8266-oled-ssd1306, if someone who have ssd1306 would move to adafruit/Adafruit_SSD1306 probably there would be less ifdef.

idk about that. perhaps, availability and / or esp8266 quirks were handled better originally, but still it feels like Adafruit option is mostly targeted at other Arduino boards.
also check out https://github.com/lexus2k/ssd1306, despite the name it handles both of these displays.

Next step may be to create a display "class" to be referenced from espurna itself for ip address/ssid and/or relay status..

maybe. depends on what exactly relays will do. e.g. do we create sort-of 'window' / region and allow external thing to fully control it, or keep some specific spaces for 'info' and only allow data input

let me think about the example / pio.ini code a bit, I'll merge the PR after that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants