Skip to content

Removed old synthesise method and fixed background in the new version#687

Merged
sguillot merged 3 commits into
xpsi-group:mainfrom
lmauviard:clean-synthesize-methods
Mar 15, 2026
Merged

Removed old synthesise method and fixed background in the new version#687
sguillot merged 3 commits into
xpsi-group:mainfrom
lmauviard:clean-synthesize-methods

Conversation

@lmauviard
Copy link
Copy Markdown
Collaborator

I realized the old synthesize method were not removed.

I also noticed a few issues while synthesizing some data:

  1. In synthesise_expo, the compute_expected_counts function was given the background in counts and not in counts/s as required.
  2. In the Signal.synthesize, the save background data was in counts/s, although it should have been in counts.
  3. Case matching for writing in Signal was using the data phases as reference, and not the input count shape.

All of the above have been fixed

@lmauviard lmauviard requested a review from sguillot March 8, 2026 16:06
lmauviard and others added 2 commits March 8, 2026 17:08
Make background 2D (phase-resolved) to be compatible with the plotting (in the last cell)
@sguillot sguillot merged commit ddeb6b6 into xpsi-group:main Mar 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants