HYCOM Grid Optimizations#61
Open
NicholasMarkou wants to merge 15 commits into
Open
Conversation
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two changes:
New method of dropping longitude >500 in HYCOM Grid
Instead of running
mask()in the project function of HYCOMGrid, we drop the last row of the DataArray, where all junk data is containedda = da[0:, :-1, ]. Notably, this must be ran before time is selected, otherwise the junk data is no longer in the last row of the DataArray. As a result, it was required to move this inside the get_map() function.Optimization of HYCOM Grid projection
In the
project()function of HYCOMGrid, there was redundant code which increased the runtime of the function. This change reduces the number of computed masks by one and reuses it when splitting the DataArray into two. Additionally,temp_da_0andtemp_da_1were removed as there was no need to recreate the DataArray before concatenating them together.