Switch WMS router to use async#98
Open
mpiannucci wants to merge 3 commits into
Open
Conversation
mpiannucci
force-pushed
the
async-exploration
branch
from
99adbf1 to
2791737
Compare
Collaborator
Author
Notes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The approach for this is to delay dask chunk downloading for
GetMaprequests to a single daskcomputecall that we call in asyncioto_thread(). The rest of the methods simply useto_thread()for now but there is a path to support a more featureful implementation.This also introduces clipping for GetMap requests to decrease the cpu/memory pressure on the rendering process, as well as decreasing the amount of chunks that need to be downloaded.