fix: use Playwright official image for ARM64 Docker#689
Open
yjnzzg2014-maker wants to merge 3 commits into
Open
fix: use Playwright official image for ARM64 Docker#689yjnzzg2014-maker wants to merge 3 commits into
yjnzzg2014-maker wants to merge 3 commits into
Conversation
Ensure inputSchema includes properties: {} for tools that take no
arguments. This fixes compatibility with strict MCP clients that
validate JSON Schema.
Fixes xpzouying#677
This test requires a real browser environment and was causing go test ./... to panic when run in environments without a browser. Fixes xpzouying#652
- Replace manual Chromium installation with Playwright's official mcr.microsoft.com/playwright image which includes Chromium ARM64 - Add docker/build.sh script for auto architecture detection - Add docker/docker-compose.arm64.yml for ARM64 builds - Update docker-compose.yml to remove Chrome-specific environment Fixes xpzouying#655
Contributor
|
Contributor
|
我来先获取 PR #689 的详细信息和代码变更。 PR #689 代码审查总体评价这是一个有价值的改进，主要解决了 ARM64 Docker 构建中 Chromium 安装不可靠的问题。整体倾向：Approve with suggestions 变更概览
详细审查意见1. ✅ Dockerfile.arm64 简化方向正确将 Ubuntu + 手动安装数十个依赖的方案，替换为官方 Playwright 镜像，显著提升了可维护性。原方案依赖 go-rod 自动下载 Chromium，在 ARM64 上确实经常出问题。 2.
|
Author
|
👋 这个 PR 修复 issue #655。使用 Playwright 官方镜像替代手动安装 Chromium，解决 arm64 Docker 环境下的 Chrome 问题。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use Playwright's official image for ARM64 Docker builds instead of manual Chromium installation.
Changes
mcr.microsoft.com/playwright:v1.50.0-jammywhich includes Chromium ARM64Problem
The previous Dockerfile tried to install Chromium dependencies manually but didn't actually install Chromium, relying on go-rod to auto-download it. This approach was unreliable for ARM64.
Solution
Use Playwright's official image which includes a properly configured Chromium for ARM64.
Testing
cd docker ./build.sh docker compose -f docker-compose.arm64.yml logs -fFixes #655