Make the VS Code extension self-contained and publishable - #14
Merged
Conversation
The extension now depends on the published xslint-lsp package and resolves the server via require.resolve, so vsce bundles the server and its engine into the .vsix instead of pointing at a repo-relative path that only works from a checkout. Adds the Marketplace manifest fields, a .vscodeignore, an extension README, npm run package/publish scripts, and @vscode/vsce. Verified vsce package produces a self-contained 2 MB vsix.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 211 211
=========================================
Hits 211 211 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@rultor merge |
Collaborator
@maxonfjvipon OK, I'll try to merge now. You can check the progress of the merge here. |
Collaborator
@maxonfjvipon Done! FYI, the full log is here (took me 1min). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares the
client/extension for the Marketplace. It now depends on the publishedxslint-lspnpm package and resolves the server withrequire.resolve("xslint-lsp"), sovsce packagebundles the server and the@maxonfjvipon/xslintengine into the.vsix— self-contained, unlike the old repo-relative../../srcpath.Adds the Marketplace manifest fields (keywords, repository/homepage/bugs), a
.vscodeignore, an extension README (the Marketplace listing),npm run package/publishscripts, and@vscode/vsce. Verified:vsce packageproducesxslint-vscode-0.0.1.vsix(2 MB, bundling xslint-lsp + the engine). Server tests, coverage, and lint are unaffected (the client stays out of their scope).