Changed API of beam element transformations active #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonlopaciuk
force-pushed
the
transformations-active
branch
from
b0ebe3d to
dd42dc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't Merge Yet – only to be released with Xtrack 0.95.0
Description
As a result of removing "special values" for
_sin_rot_sto enable/disable transformations (instead we simply store angles, shifts, and zero values mean disabled) the API for transformations was simplified. However, I noticed that Xcoll was using one of the functions I deleted in one place, so I have reintroduced it as a proper method of theBaseElement, which requires the following change.Checklist
Mandatory:
Optional: