-
Notifications
You must be signed in to change notification settings - Fork 57
TPSA in Xsuite Matching (Interface to MAD-NG) #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
babreufig
wants to merge
25
commits into
xsuite:main
Choose a base branch
from
babreufig:feature/madng_jacobians
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport for full twiss matching (only without tpsa yet, coming soon)
Contributor
Author
|
Functionality is ready. Needs follow-up because new MAD-NG version breaks two tests that rely on calculating chromaticities, as phix/phiy in MAD-NG 1.1.8 changed by a factor 2. This can be found in this commit (MethodicalAcceleratorDesign/MAD-NG@5c87e03) @giadarol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements MAD-NG TPSA Action to use MAD-NG tracked damaps to acquire optical parameters.
Important: This pull request requires at least MAD-NG version 1.1.8. There is a discrepancy in the chromaticity calculation between MAD-NG version 1.1.7 and 1.1.8, where the
phixis by a factor 2 smaller in the new version. This seems to be a different convention(?). Needs a follow-up because this affects Ax/Bx/Ay/By functions which are then different between Xsuite and MAD-NG. For reference: MethodicalAcceleratorDesign/MAD-NG@5c87e03Depends on xsuite/xdeps#106
Mandatory: