Skip to content

Add exit aperture after slicing. #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −13
Open

Add exit aperture after slicing. #727

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e7038f
Add exit aperture after slicing.
freddieknets Nov 24, 2025
7744634
Improve readability
szymonlopaciuk Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions xtrack/slicing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,20 +280,10 @@ def _slice_element(self, name, element, chosen_slicing, _edge_markers=True) -> O
name=name,
)

if _edge_markers:

if isinstance(element, xt.Replica):
element = element.resolve(self._line)
_buffer = element._buffer

entry_marker, exit_marker = f'{name}_entry', f'{name}_exit'
self._line._element_dict[entry_marker] = xt.Marker(_buffer=_buffer)
self._line._element_dict[exit_marker] = xt.Marker(_buffer=_buffer)
slices_to_add = [entry_marker] + slices_to_add + [exit_marker]

# Handle aperture
if isinstance(element, xt.Replica):
element = element.resolve(self._line)

# Handle aperture
if (hasattr(element, 'name_associated_aperture')
and element.name_associated_aperture is not None):
new_slices_to_add = []
Expand All @@ -308,7 +298,19 @@ def _slice_element(self, name, element, chosen_slicing, _edge_markers=True) -> O
new_slices_to_add += [aper_name]
aper_index += 1
new_slices_to_add += [nn]
slices_to_add = new_slices_to_add
# Final aperture
aper_name = f'{name}_aper..{aper_index}'
self._line._element_dict[aper_name] = xt.Replica(
parent_name=element.name_associated_aperture)

slices_to_add = new_slices_to_add + [aper_name]

if _edge_markers:
_buffer = element._buffer
entry_marker, exit_marker = f'{name}_entry', f'{name}_exit'
self._line._element_dict[entry_marker] = xt.Marker(_buffer=_buffer)
self._line._element_dict[exit_marker] = xt.Marker(_buffer=_buffer)
slices_to_add = [entry_marker] + slices_to_add + [exit_marker]

return slices_to_add

Expand Down