Skip to content

Conversation

@lgiacome
Copy link
Collaborator

@lgiacome lgiacome commented Jun 20, 2024

Description

Originally opened by @lgiacome in the gitlab repo: https://gitlab.cern.ch/IRIS/pywit/-/merge_requests/32

We implement the possibility to add a constant term (i.e. which doesn't vary when searching the instability threshold) to the detuning coefficients.
A new root-solving algorithm is also allowed (bisect) - now both newton and bisect may be used.
Includes several tests.

Checklist

Mandatory:

  • I have added tests to cover my changes
  • All the tests are passing, including my new ones
  • I described my changes in this PR description

Optional:

  • The code I wrote follows good style practices (see PEP 8 and PEP 20).
  • I have updated the docs in relation to my changes, if applicable
  • I have tested also GPU contexts

Copy link
Collaborator

@nmounet nmounet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @lgiacome for the great work!
I just added the possibility to change the root-solving algorithm (newton or bisect) - both work in the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants