Handle IME-transformed printable input - #6024
Open
yasuhito wants to merge 1 commit into
Open
Conversation
This was referenced Jul 27, 2026
Open
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5348
This changes printable key handling to give
beforeinput/inputa chance to provide the authoritative text before xterm.js sends the rawkeydowncharacter.Some IMEs such as SKK commit certain characters without a
compositionstart/compositionendsequence. In Chromium-based runtimes, a key likeacan arrive as:keydown: raw keyabeforeinput/input: committed IME textあBefore this change, xterm.js sent the raw keydown text immediately, so terminal apps received
ainstead ofあ. Multi-key SKK input such askacan still work because the first key enters IME state and the committed text arrives later.The fix:
beforeinputfirst, preventing the DOM mutation when possibleinputifbeforeinputis unavailableAdded unit coverage for:
beforeinputdata replacing raw printable keydown data (a->あ)a->a)beforeinput/inputarrivesValidation run locally:
npm run buildnpm run esbuildnode ./bin/test_unit.js out-esbuild/browser/Terminal.test.jsnpm run test-unitnpm run lint-changes