This repository was archived by the owner on Mar 15, 2025. It is now read-only.
Add local file and md5 fields to the cache, and use them to implement a verify function.#44
Open
yakovlevtx wants to merge 3 commits into
Open
Add local file and md5 fields to the cache, and use them to implement a verify function.#44yakovlevtx wants to merge 3 commits into
yakovlevtx wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the features I use with the GOG downloader is the md5 verify function that checks downloaded files against the website md5.
This implements the verify function for the humble bundle downloader.
I noticed the problems that happened with relying totally on the humble bundle website md5, so I generate the md5 on download and warn if it is inconsistent with the website. The downloaded file's md5 is then used for subsequent verification. (The warning is reported again when verifying.)
Because I had to update the cache file format, if required fields are missing during verification the updates will query the website to see if it can generate them before continuing on to the verification step.