Feature/run sat on repo and upload reports#14
Merged
Conversation
Summary by CodeHawkyStatus
Summary
Risk
Review Path
Open Questions
|
There was a problem hiding this comment.
The pull request introduces a repository-level SAT runner and a refactor/move for the repo fetcher assets. The integration between the Docker runner and MinIO client, as well as the new SAT runner, overall appears well structured. However, there are a few issues identified that could potentially affect the reliability and observability of the indexing pipeline.
Key concerns are:
- The new control flow in
clone_repodoes not log or handle SAT runner failures at all—if the SAT runner fails (container fails or exits with non-zero), this will go unnoticed and the system will not alert or propagate that failure, leading to silent data gaps. - The SAT runner uploads a report even if the analysis tool fails, but this is not documented nor surfaced to any monitoring/alerting system.
See inline comments for actionable changes.
Summary by CodeHawkyStatus
Summary
Risk
Review Path
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a repository-level SAT runner flow that runs after the repo fetch/upload step and uploads analysis reports back to object storage. This also reorganizes the code indexing Docker assets by moving the repo fetcher into its own
repo_fetcherpackage.Related Issue
Closes #13
Type of Change
Changes Made
codehawk/code_index/repo_fetcher/for clearer code index organization.sat_runnerDocker image and script that:SAT_COMMAND.DockerRunnerto launch the SAT runner container after the repo fetcher completes.await asyncio.to_thread(...)before starting SAT analysis, preventing the SAT runner from downloading the archive before upload finishes.repo-archives/.../source.tar.gzsat-reports/.../sat-report.jsonSAT_RUNNER_IMAGEwiring todocker-compose.yaml.How to Test
CODE_INDEXER_IMAGEandSAT_RUNNER_IMAGE.source.tar.gzunder therepo-archivesprefix.sat-reportsprefix.Checklist
Breaking Changes
None expected.