Skip to content

Throw an exception if a error occurs in the following 22 functions: #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2025

Conversation

LZCZ
Copy link
Contributor

@LZCZ LZCZ commented Apr 5, 2025

PR Details

Throw an exception if a error occurs in the following 23 functions:

Description

  • set_doc_props
  • set_header_footer
  • set_page_layout
  • set_page_margins
  • set_panes
  • set_row_outline
  • set_row_style
  • set_row_visible
  • set_sheet_background
  • set_sheet_background_from_bytes
  • set_sheet_col
  • set_sheet_dimension
  • set_sheet_name
  • set_sheet_props
  • set_sheet_view
  • set_sheet_visible
  • set_workbook_props
  • ungroup_sheets
  • unmerge_cell
  • update_linked_value
  • cell_name_to_coordinates
  • open_reader

Related Issue

Motivation and Context

Make the function more compliant with Python conventions.

How Has This Been Tested

pass test_excelize.py test with coverage

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- close
- set_doc_props
- set_header_footer
- set_page_layout
- set_page_margins
- set_panes
- set_row_outline
- set_row_style
- set_row_visible
- set_sheet_background
- set_sheet_background_from_bytes
- set_sheet_col
- set_sheet_dimension
- set_sheet_name
- set_sheet_props
- set_sheet_view
- set_sheet_visible
- set_workbook_props
- ungroup_sheets
- unmerge_cell
- update_linked_value
- cell_name_to_coordinates
- open_reader
@xuri xuri changed the title Throw an exception if a error occurs in the following 23 functions: Throw an exception if a error occurs in the following 22 functions: Apr 6, 2025
Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5082cae) to head (1bd4033).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines         2233      2324   +91     
=========================================
+ Hits          2233      2324   +91     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xuri xuri merged commit 06fc248 into xuri:main Apr 6, 2025
19 checks passed
@LZCZ LZCZ deleted the bugfix3 branch April 12, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants