Skip to content

修复在使用MyBatis的trim标签生成动态SQL时潜在的语法错误#3939

Merged
xuxueli merged 2 commits intoxuxueli:masterfrom
izhangzhiqing:master
Apr 5, 2026
Merged

修复在使用MyBatis的trim标签生成动态SQL时潜在的语法错误#3939
xuxueli merged 2 commits intoxuxueli:masterfrom
izhangzhiqing:master

Conversation

@izhangzhiqing
Copy link
Copy Markdown
Contributor

@izhangzhiqing izhangzhiqing commented Mar 26, 2026

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

The description of the PR:

代码分支:master

问题描述:在使用 MyBatis 的 trim 标签生成动态 SQL 时,prefixOverrides 中内容存在潜在语法错误(无法去除首个"OR"关键字)。

目前代码写法对于功能没有任何影响,只是发现有潜在问题,想要完善一下。

问题代码示例:

<trim prefix="WHERE" prefixOverrides="AND | OR" >
  ...
</trim>

应该调整为:

<trim prefix="WHERE" prefixOverrides="AND |OR ">
  ...
</trim>

在使用 MyBatis 的 trim标签时,prefixOverrides 属性会忽略通过管道符分隔的文本序列(注意此例中的空格是必要的)。

在 trim 标签的处理类 org.apache.ibatis.scripting.xmltags.TrimSqlNode 的 applyPrefix 方法中," OR"中的空格会导致以 “OR”开头的子句条件匹配失败,无法删除子句句首的"OR",生成有语法错误的 SQL。

for (String toRemove : prefixesToOverride) {
    if (trimmedUppercaseSql.startsWith(toRemove)) {
        sql.delete(0, toRemove.trim().length());
        break;
    }
}

@xuxueli xuxueli merged commit 8221c75 into xuxueli:master Apr 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants