refactor(install): unify install/update paths on install.sh#198
Open
floodsung wants to merge 1 commit into
Open
refactor(install): unify install/update paths on install.sh#198floodsung wants to merge 1 commit into
floodsung wants to merge 1 commit into
Conversation
install.sh becomes the single source of truth for both fresh installs and
`metabot update` / `mb update`. Previously three parallel code paths existed
and had drifted (e.g. install.sh was missing the skill-hub skill install;
bin/metabot did not install phone-call/skill-hub that bin/mb did).
- install.sh no longer writes inline mm()/mb() bash functions to
~/.bash_aliases. Those functions shadowed the standalone
~/.local/bin/{mm,mb} executables on PATH and caused new subcommands like
`mb skills` to silently fall through to the help branch. A migration step
strips any legacy blocks from an existing ~/.bash_aliases.
- install.sh Phase 6 now installs the skill-hub skill and deploys it to the
bot workspace; auto-refreshes lark-cli skills on re-run instead of
re-prompting when they are already installed.
- bin/metabot update and bin/mb update collapse to `exec bash install.sh`.
install.sh already handles git pull + self-re-exec + .env-guarded Phase 4
+ Phase 8 PM2 restart.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
|
Status check on this PR after ~3 weeks — I verified the original motivation against current main:
So the PR's value is intact, but it now conflicts with PR #202's Kimi engine selection logic on Two reasonable paths:
I'd lean toward (2) — the original unification was a single-PR refactor with three coupled concerns; in retrospect smaller PRs would have avoided exactly this rot. Your call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/.bash_aliases`. Shell functions take priority over PATH executables, so the inline `mb()` (which lacks the `skills` subcommand) shadowed the full `/.local/bin/mb` — `mb skills list` silently fell through to the help branch. Migration step strips legacy blocks from any existing `~/.bash_aliases`.Net diff: ~43 insertions, ~390 deletions.
Test plan
🤖 Generated with Claude Code