chore(cluster): teardown P2P federation (Phase 4 — DO NOT MERGE)

[floodsung]

⚠️ DO NOT MERGE — REVIEW ONLY

This PR is intentionally kept in draft so Flood can review the full diff in the morning before any merge. It removes a substantial amount of code (~4,000 LOC) and the user wants to eyeball it before it lands.

Do not mark this PR ready-for-review or merge it without explicit go-ahead.

---

Summary

Phase 4 of the central-architecture pivot. The central memory + skill hub server (Phase 1) has already shipped as PR #304. This PR removes the entire P2P federation surface so the central server becomes the single cross-instance sync path going forward. Local single-instance MetaBot behavior is unchanged.

What goes away

Deleted modules

• src/cluster/mdns.ts — LAN auto-discovery (_metabot._tcp.local)
• src/cluster/peer-token.ts — stable reader-token loader (~/.metabot/peer-token)
• src/api/peer-manager.ts — PeerManager class + 30s polling + handshake + skill/memory caches
• src/api/routes/peer-memory-routes.ts — /api/peer-memory/*
• src/api/routes/search-routes.ts — federated fan-out (/api/search/federated)

Deleted tests

• tests/peer-manager.test.ts, tests/peer-token.test.ts, tests/mdns.test.ts
• tests/federated-search.test.ts, tests/skill-hub-visibility.test.ts, tests/config-cluster.test.ts

Surgical edits (peer code stripped, files retained)

• src/index.ts — drop PeerManager / mdns / peer-token bootstrap + shutdown
• src/api/http-server.ts — drop peer-memory + search route mounts, drop /api/peer-handshake auth exemption, drop peerManager from ApiServerOptions / RouteContext / /api/health payload
• src/api/routes/{bot,task,team,manifest,skill-hub}-routes.ts — strip peer routing, aggregation, install branches
• src/api/routes/types.ts / index.ts — drop peerManager field + peer-route exports
• src/web/ws-server.ts — drop peerManager param + peer-bot fallback in handleChat
• src/memory/memory-server.ts — drop peerTokenLookup reader path (Pragmatic v1 peer-token gate)
• src/config.ts — drop peers config (env vars + bots.json field)
• bots.example.json — drop peers array
• bin/mm — mm search becomes local-only; peer-search / peer-get cases removed; help text trimmed
• tests/memory-{proxy-auth,default-private,server}.test.ts — peer-token cases removed, local/admin cases preserved

Config + docs

• .env.example — dropped MDNS_*, METABOT_PEERS, METABOT_PEER_*, METABOT_DISCOVERY_MODE, METABOT_CLUSTER_ID, METABOT_CLUSTER_SECRET, METABOT_DYNAMIC_PEER_DEMOTE_MS, METABOT_PEER_TOKEN_PATH. Left METABOT_CLUSTER_URL reserved for central mode.
• README.md / README_EN.md / docs/internal/architecture.md / CLAUDE.md — replaced federation/mDNS sections with single-sentence pointers at docs/internal/central-architecture.md

What stayed

• src/cluster/identity.ts — still used by config.ts for instance identity. clusterId / clusterUrl / discoveryMode fields remain in the InstanceIdentity struct but are no longer consumed for peer logic. A follow-up can remove them; not load-bearing right now.
• src/api/routes/memory-proxy.ts — Phase 2 (metabot central client mode) will refactor this.
• skill-hub-routes.ts visibility filter (visibilityFilterForRequest) and X-MetaBot-Origin handling — kept as defense-in-depth though no caller currently sends that header.

Verification

./node_modules/.bin/tsc --noEmit       # → 0 errors
./node_modules/.bin/eslint src/ tests/ # → 0 errors, 2 pre-existing warnings
./node_modules/.bin/vitest run         # → 329/330 passing

The one failing test is a pre-existing port-collision flake in central/tests/helpers.ts (introduced by PR #304). Different test files race on port 18200 because the let nextPort = 18200 counter is module-scoped — when vitest runs the central/tests/* files in parallel workers, each worker gets its own copy of the counter and they collide. The audit test passes in isolation. Not caused by this PR. Worth fixing in a separate small PR.

Test plan

• Confirm the deletion list matches the central-architecture spec
• Spot-check src/index.ts for any leftover peer references in the boot/shutdown path
• Spot-check src/api/http-server.ts for any leftover peerManager plumbing
• mm search still works against local memory after deploy
• mb skills list still lists local skills
• Discuss whether src/cluster/identity.ts peer-related fields can come out in a follow-up

🤖 Generated with Claude Code

[floodsung]

Closed: superseded by main history rewrite. 2026-05-18 we reset main back to b988be1 (pre-P2P) and cherry-picked the 3 non-P2P keepers (#293/#294/#295). P2P federation code no longer exists on main, so a teardown PR is moot. Pre-revert state archived at tag archive/p2p-era-end-20260518-main.