fix: missing reader.skipName() in ShapeStrokeParser default case#416
Open
burakimdatt wants to merge 5 commits intoxvrh:masterfrom
Open
fix: missing reader.skipName() in ShapeStrokeParser default case#416burakimdatt wants to merge 5 commits intoxvrh:masterfrom
burakimdatt wants to merge 5 commits intoxvrh:masterfrom
Conversation
…rsions for characters, matcher, material_color_utilities, meta, and test_api packages. Enhance FillContent class to support PathFillType.
…s in design and functionality.
Fixes path fillType assignment timing in both FillContent and GradientFillContent to occur during draw/bounds operations rather than initialization.
Aligns with other parsers (e.g. ShapeFillParser) when skipping unknown stroke keys. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default branch only called
skipValue(), unlikeShapeFillParserand other parsers that useskipName()+skipValue()for unknown keys. This aligns behavior and avoids leaving the name token unconsumed.Made with Cursor