fix: corrected FileLottie.hashCode to prevent cache memory leak#417
Merged
xvrh merged 1 commit intoJun 1, 2026
Merged
Conversation
Owner
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From issue #412:
Problem
FileLottie.operator==comparedfile.path, buthashCodereturnedfile.hashCode(the identity hash of theio.Fileobject). This violatedthe
hashCode/==contract: twoFileLottieinstances pointing to thesame path were considered equal but produced different hash codes.
As a result,
sharedLottieCache.putIfAbsent(this, ...)always missed ona hash lookup, inserting a new cache entry every time the same file was
loaded. Over time this caused the cache to grow without bound, leaking
memory.
Fix
Change
hashCodeto usefile.path.hashCodeso it is consistent withthe equality comparison.