Skip to content

Inline table don't detect block generated by other macro which contains MetaDataBlock#1

Open
Josue-T wants to merge 2 commits intomasterfrom
XLIT-22
Open

Inline table don't detect block generated by other macro which contains MetaDataBlock#1
Josue-T wants to merge 2 commits intomasterfrom
XLIT-22

Conversation

@Josue-T
Copy link
Copy Markdown
Contributor

@Josue-T Josue-T commented Mar 20, 2026

Jira URL

https://jira.xwiki.org/browse/XLIT-22

Changes

Description

Improve the way to search the macro block to also work when have a MetaDataBlock

Clarifications

So we use the getBlocks method with a ClassBlockMatcher and the axe on DESCENDANT which will search all corresponding block even if there are a block between the parent and the child.

Executed Tests

Tested with the step to reproduce the issue of the JIRA issue and the fix seem fixing the issue.

Maybe doing more test on some edges would be good to ensure that no regressions was introduced.

Expected merging strategy

  • Prefers squash: Yes

@Josue-T Josue-T requested a review from douakli March 20, 2026 14:08
Copy link
Copy Markdown
Contributor

@douakli douakli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the investigation and the proposed fix Josué.
I do think we need a broader matching than just children, but recursively finding any table row or table cell through the whole tree is too broad.
We shouldn't be listing rows contained inside rows, or cells contained inside cells.

Thanks,
Dorian.

…ch contains MetaDataBlock

* Improve block filtering
@Josue-T Josue-T requested a review from douakli April 3, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants