Conversation
…ch contains MetaDataBlock
douakli
requested changes
Mar 26, 2026
Contributor
douakli
left a comment
There was a problem hiding this comment.
Thanks for the investigation and the proposed fix Josué.
I do think we need a broader matching than just children, but recursively finding any table row or table cell through the whole tree is too broad.
We shouldn't be listing rows contained inside rows, or cells contained inside cells.
Thanks,
Dorian.
…ch contains MetaDataBlock * Improve block filtering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XLIT-22
Changes
Description
Improve the way to search the macro block to also work when have a
MetaDataBlockClarifications
So we use the
getBlocksmethod with aClassBlockMatcherand the axe onDESCENDANTwhich will search all corresponding block even if there are a block between the parent and the child.Executed Tests
Tested with the step to reproduce the issue of the JIRA issue and the fix seem fixing the issue.
Maybe doing more test on some edges would be good to ensure that no regressions was introduced.
Expected merging strategy