XWIKI-21417: BaseObject#set always set the metadata dirty flag of the owner doc to true #4064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… owner doc to true
* Provide a new API to retrieve current property or create a new one,
use that call in all fromString and fromStringArray methods
tmortagne
reviewed
Apr 17, 2025
...m-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/PropertyClass.java
Outdated
Show resolved
Hide resolved
… owner doc to true
* Introduce new generic APIs allowing to set given BaseProperty values
and provide implementations
tmortagne
reviewed
Apr 23, 2025
| * Retrieve the already existing base property based on current name, or create a new one. | ||
| * | ||
| * @return the existing {@link BaseProperty} or a new one. | ||
| * @since 17.3.0RC1 |
tmortagne
reviewed
Apr 23, 2025
| @@ -366,7 +366,7 @@ public void set(String fieldname, java.lang.Object value, XWikiContext context) | |||
| PropertyClass pclass = (PropertyClass) bclass.get(fieldname); | |||
| BaseProperty prop = (BaseProperty) safeget(fieldname); | |||
| if ((value instanceof String) && (pclass != null)) { | |||
| prop = pclass.fromString((String) value); | |||
| prop = pclass.fromString((String) value, prop); | |||
There was a problem hiding this comment.
I'm not sure it's really the cleanest code in general, it's good to reuse the property, but it's a bit strange to re-put it in the object.
tmortagne
reviewed
Apr 23, 2025
| @Unstable | ||
| protected BaseProperty getCurrentOrNewProperty(BaseProperty property) | ||
| { | ||
| return (property != null) ? property : newProperty(); |
There was a problem hiding this comment.
It might be outside the scope of this issue, but I'm wondering if the xclass should "auto-repair" the property if it does not have the right type. Right now, the following code might fail if getCurrentOrNewProperty gives a property of the wrong type (compared to the previous situation where that code was expecting to always get a new property).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
Changes
Description
Clarifications
Screenshots & Video
Executed Tests
Ran
mvn clean install -Pqualityon both oldcore and legacy-oldcore and executed docker test inxwiki-platform-appwithinminutes-test-docker.Expected merging strategy