XWIKI-23129: Add an end of DOM
UIXP
#4085
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-23129
Changes
Description
Clarifications
div
, a dialog element has a default look (white background and black border). We update bootstrap to keep the class while updating the nature of the nodes without it impacting the looks.Screenshots & Video
2025-04-24.10-26-02.mp4
Executed Tests
Manual tests on the three modals.
Checked the automated test paths, which is IMO the most likely thing that could have gotten broken by this:
xwiki-platform/xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-pageobjects/src/main/java/org/xwiki/flamingo/skin/test/po/ExportModal.java
Line 42 in bfa5b81
Successfully built:
mvn clean install -f xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/ -Pquality
mvn clean install -f xwiki-platform-core/xwiki-platform-web; mvn clean install -f xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-ui -Pquality; mvn clean install -f xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-test/xwiki-platform-notifications-test-docker
(note that without building the whole xwiki-platform-web module, those tests were failing because the distrib used in the docker tests did not get the updated template)Expected merging strategy