Skip to content

XWIKI-23129: Add an end of DOM UIXP #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Apr 24, 2025

Jira URL

https://jira.xwiki.org/browse/XWIKI-23129

Changes

Description

  • Added the UIXP
  • Used the UIX for one of the blocking modals for XWIKI-22669
  • Handled the #exportModal and #exportTreeModal move
  • Changed the nature of the modal elements to avoid overcomplicated/low reliability ARIA markup combinations.
  • Updated the bootstrap style for modal to make it look as it used to with this new DOM.

Clarifications

  • Since the exportModal and exportTreeModal were defined in flamingo VTL templates, I decided to just move it before the UIXP in their new template. Note that in all cases, this new template should be loaded, and it's not much of an issue if we load the modals if we don't have the buttons to open them, they stay hidden by default.
  • On the opposite to a div, a dialog element has a default look (white background and black border). We update bootstrap to keep the class while updating the nature of the nodes without it impacting the looks.

Screenshots & Video

Screenshot from 2025-04-24 10-07-57

2025-04-24.10-26-02.mp4

Executed Tests

Manual tests on the three modals.
Checked the automated test paths, which is IMO the most likely thing that could have gotten broken by this:

Successfully built:

  • mvn clean install -f xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/ -Pquality
  • mvn clean install -f xwiki-platform-core/xwiki-platform-web; mvn clean install -f xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-ui -Pquality; mvn clean install -f xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-test/xwiki-platform-notifications-test-docker (note that without building the whole xwiki-platform-web module, those tests were failing because the distrib used in the docker tests did not get the updated template)

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • None, this is a DOM change that applies on all pages so it's pretty dangerous.

Sereza7 added 6 commits April 22, 2025 17:38
* Added the UIXP
* Used the UIXP for one of the blocking modals for XWIKI-22669

TODO: handle the #exportModal and #exportTreeModal in a similar way. Note that they are currently defined in a .vm so the exact implementation will probably not be the same.
* Handled the #exportModal and #exportTreeModal move
* Changed the nature of the watchmodal
* Updated the styles of the dialog modal containers.
* Removed unwanted change
* Removed unwanted change
@Sereza7 Sereza7 marked this pull request as ready for review April 24, 2025 09:01
@Sereza7 Sereza7 requested a review from surli April 24, 2025 09:01
@Sereza7
Copy link
Contributor Author

Sereza7 commented Apr 24, 2025

@surli I'm assigning this one to you since you were already part of the discussion that is related to the changes proposed by this ticket and PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants