Skip to content

XWIKI-23169: The pages created by an user with script right viewed from the link from the 'Delete user' modal are not filtered properly anymore #4153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

manuelleduc
Copy link
Contributor

@manuelleduc manuelleduc commented May 12, 2025

Jira URL

https://jira.xwiki.org/browse/XWIKI-23169

Changes

Description

  • provide a new filter parameter on the documents macro
  • pass a custom query param on the link in the error message, and use this param on the index page to define the default filter

Clarifications

TODO:

  • improve parameters escaping
  • check for missing translations
  • add functional test

Screenshots & Video

N/A

Executed Tests

  • run tests

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • stable-16.10.x

{{liveData
id="$livedataId"
properties="$propertiesStr"
source="liveTable"
sourceParameters="$escapetool.url($sourceParameters)"
#if ($filters) filters="$filters"#end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs escaping, otherwise this allows remote code execution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…om the link from the 'Delete user' modal are not filtered properly anymore
@manuelleduc manuelleduc marked this pull request as ready for review May 13, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants