XWIKI-23720: The watch notification button is a link instead of an actual button#5164
Merged
surli merged 1 commit intoxwiki:masterfrom Feb 10, 2026
Merged
XWIKI-23720: The watch notification button is a link instead of an actual button#5164surli merged 1 commit intoxwiki:masterfrom
surli merged 1 commit intoxwiki:masterfrom
Conversation
…tual button * Fixed the DOM
surli
approved these changes
Feb 10, 2026
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-23720
Changes
Description
Clarifications
Screenshots & Video
Video demo of the change in action:
2026-02-09.14-12-06.mp4
Executed Tests
Manual tests on my local instance (see video above).
Built the changes with
mvn clean install -f xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-ui -Pqualitysuccesfully.I checked the test objects and it seems like the affected object is the WatchButton:
xwiki-platform/xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-test/xwiki-platform-notifications-test-pageobjects/src/main/java/org/xwiki/platform/notifications/test/po/NotificationWatchButtonElement.java
Lines 35 to 36 in 5f90563
This is used in a few tests,
NotificationsSettingsIT#filterAndWatchedPageis one of them so I decided to check that docker tests were okay withmvn clean install -f xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-test/xwiki-platform-notifications-test-docker/. The docker tests passed successfully after a few minutes running on my machine.Expected merging strategy