Skip to content

Comments

XWIKI-23720: The watch notification button is a link instead of an actual button#5164

Merged
surli merged 1 commit intoxwiki:masterfrom
Sereza7:XWIKI-23720
Feb 10, 2026
Merged

XWIKI-23720: The watch notification button is a link instead of an actual button#5164
surli merged 1 commit intoxwiki:masterfrom
Sereza7:XWIKI-23720

Conversation

@Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Feb 9, 2026

Jira URL

https://jira.xwiki.org/browse/XWIKI-23720

Changes

Description

  • Replaced the imprecise DOM.

Clarifications

  • See the ticket description for the motivation of this change.

Screenshots & Video

Video demo of the change in action:

2026-02-09.14-12-06.mp4

Executed Tests

Manual tests on my local instance (see video above).
Built the changes with mvn clean install -f xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-ui -Pquality succesfully.
I checked the test objects and it seems like the affected object is the WatchButton:

This is used in a few tests, NotificationsSettingsIT#filterAndWatchedPage is one of them so I decided to check that docker tests were okay with mvn clean install -f xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-test/xwiki-platform-notifications-test-docker/. The docker tests passed successfully after a few minutes running on my machine.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • None.

@Sereza7 Sereza7 requested a review from surli February 9, 2026 13:30
@surli surli merged commit ec2bfed into xwiki:master Feb 10, 2026
3 checks passed
@github-actions
Copy link

💚 All backports created successfully

Status Branch Result
stable-17.10.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants