XWIKI-23719: The tree finder uses a hard-coded icon#5168
Open
Sereza7 wants to merge 2 commits intoxwiki:masterfrom
Open
XWIKI-23719: The tree finder uses a hard-coded icon#5168Sereza7 wants to merge 2 commits intoxwiki:masterfrom
Sereza7 wants to merge 2 commits intoxwiki:masterfrom
Conversation
* Updated the style to replace the hard-coded non-semantic icon with a standard one. * Changed the webjar url so that it would be evaluated on load. In javascript we still rely on the velocity API to provide standard icons. * Updated the styles so that the changes in DOM do not affect presentation too much.
* Removed unneeded CSS rule
mflorea
requested changes
Feb 11, 2026
| #foreach ($name in $iconNames) | ||
| #set ($discard = $icons.put($name, $services.icon.renderHTML($name))) | ||
| #end | ||
| #[[*/ |
Member
There was a problem hiding this comment.
I prefer we use the REST API. See https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-api/src/main/resources/js/attachment/move.js#L35 for an example. We're missing a utility on the client side to simplify this (if you have time to add it, it would be awesome), but I think it's still better than mixing Velocity with JavaScript.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-23719
Changes
Description
Clarification
gapvalue for the flex. Usually .5em works well enough. We don't have a spacing policy yet so I figured it was okay.Screenshots & Video
After the changes proposed in the PR were applied:
Executed Tests
Built the changes successfully with
mvn clean install -f xwiki-platform-core/xwiki-platform-tree/xwiki-platform-tree-webjar -Pquality.Manual tests on my local instance (see screenshot above).
AFAICS there's no test covering the specific DOM changed: https://github.com/search?q=org%3Axwiki%20xtree-finder&type=code
In any case, the icon itself was non interactive and didn't have a node so it's very unlikely tests relied on it. What could break some selectors is that we nested the
.xtree-finderinput in a new DIV.xtree-finder-container.Expected merging strategy