Update dependency fast-xml-parser to v5.3.6 [SECURITY]#5201
Open
renovate-bot wants to merge 1 commit intoxwiki:masterfrom
Open
Update dependency fast-xml-parser to v5.3.6 [SECURITY]#5201renovate-bot wants to merge 1 commit intoxwiki:masterfrom
renovate-bot wants to merge 1 commit intoxwiki:masterfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
5.3.4→5.3.6GitHub Vulnerability Alerts
CVE-2026-26278
Summary
The XML parser can be forced to do an unlimited amount of entity expansion. With a very small XML input, it’s possible to make the parser spend seconds or even minutes processing a single request, effectively freezing the application.
Details
There is a check in
DocTypeReader.jsthat tries to prevent entity expansion attacks by rejecting entities that reference other entities (it looks for & inside entity values). This does stop classic “Billion Laughs” payloads.However, it doesn’t stop a much simpler variant.
If you define one large entity that contains only raw text (no & characters) and then reference it many times, the parser will happily expand it every time. There is no limit on how large the expanded result can become, or how many replacements are allowed.
The problem is in
replaceEntitiesValue()insideOrderedObjParser.js. It repeatedly runsval.replace()in a loop, without any checks on total output size or execution cost. As the entity grows or the number of references increases, parsing time explodes.Relevant code:
DocTypeReader.js(lines 28–33): entity registration only checks for &OrderedObjParser.js(lines 439–458): entity replacement loop with no limitsPoC
Impact
This is a straightforward denial-of-service issue.
Any service that parses user-supplied XML using the default configuration is vulnerable. Since Node.js runs on a single thread, the moment the parser starts expanding entities, the event loop is blocked. While this is happening, the server can’t handle any other requests.
In testing, a payload of only a few kilobytes was enough to make a simple HTTP server completely unresponsive for several minutes, with all other requests timing out.
Workaround
Avoid using DOCTYPE parsing by
processEntities: falseoption.CVE-2026-25896
Entity encoding bypass via regex injection in DOCTYPE entity names
Summary
A dot (
.) in a DOCTYPE entity name is treated as a regex wildcard during entity replacement, allowing an attacker to shadow built-in XML entities (<,>,&,",') with arbitrary values. This bypasses entity encoding and leads to XSS when parsed output is rendered.Details
The fix for CVE-2023-34104 addressed some regex metacharacters in entity names but missed
.(period), which is valid in XML names per the W3C spec.In
DocTypeReader.js, entity names are passed directly toRegExp():An entity named
l.produces the regex/&l.;/gwhere.matches any character, including thetin<. Since DOCTYPE entities are replaced before built-in entities, this shadows<entirely.The same issue exists in
OrderedObjParser.js:81(addExternalEntities), and in the v6 codebase -EntitiesParser.jshas avalidateEntityNamefunction with a character blacklist, but.is not included:Shadowing all 5 built-in entities
l./&l.;/g<g./&g.;/g>am./&am.;/g&quo./&quo.;/g"apo./&apo.;/g'PoC
No special parser options needed -
processEntities: trueis the default.When an app renders
result.root.textin a page (e.g.innerHTML, template interpolation, SSR), the injected<img onerror>fires.&can be shadowed too:Impact
This is a complete bypass of XML entity encoding. Any application that parses untrusted XML and uses the output in HTML, SQL, or other injection-sensitive contexts is affected.
</>/&/"/'with arbitrary stringsSuggested fix
Escape regex metacharacters before constructing the replacement regex:
For v6, add
.to the blacklist invalidateEntityName:Severity
Entity decoding is a fundamental trust boundary in XML processing. This completely undermines it with no preconditions.
Release Notes
NaturalIntelligence/fast-xml-parser (fast-xml-parser)
v5.3.6: Entity security and performanceCompare Source
maxEntitySize,maxExpansionDepth,maxTotalExpansions,maxExpandedLength,allowedTags,tagFilterFull Changelog: NaturalIntelligence/fast-xml-parser@v5.3.5...v5.3.6
v5.3.5Compare Source
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.