XWIKI-24060: A badly parsed logged TransactionException can break the…#5377
Open
lucaa wants to merge 1 commit intoxwiki:masterfrom
Open
XWIKI-24060: A badly parsed logged TransactionException can break the…#5377lucaa wants to merge 1 commit intoxwiki:masterfrom
lucaa wants to merge 1 commit intoxwiki:masterfrom
Conversation
… log displayer (and the script than calls it) * Added null checks for the usage of the causes variable in the TransactionException, for safety
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… log displayer (and the script than calls it)
Jira URL
https://jira.xwiki.org/browse/XWIKI-24060
Changes
Description
While a more complete and complex fix is proposed by @tmortagne in the issue, this change adds some basic null checks in the TransactionException, to prevent the errors from happening, if ever the TransactionException is badly deserialized.
Executed Tests
I ran the build for the xwiki-platform-store module and also tested these changes at runtime, on a 16.10.11 instance where I hit the issue (actually its duplicate XWIKI-24186 ), then I patched with these changes and the display of extension was no longer blocked.
Expected merging strategy