Skip to content

[Misc] Fix misspellings in the remaining front-end sources, poms and XML configuration - #6082

Merged
vmassol merged 1 commit into
masterfrom
misc-typos-batch16
Aug 3, 2026
Merged

[Misc] Fix misspellings in the remaining front-end sources, poms and XML configuration#6082
vmassol merged 1 commit into
masterfrom
misc-typos-batch16

Conversation

@vmassol

@vmassol vmassol commented Aug 3, 2026

Copy link
Copy Markdown
Member

Closes the source spelling sweep that #6079 started: the 53 remaining sites, over 40 files and 13 top-level modules. python3 docs/spellscan.py scan-src now returns zero, as scan and scan-wiki already did after #6075 and #6077.

Module Sites
node (the Vue/TypeScript packages) 31
search 4
flamingo, realtime 3 each
logging, oldcore, wiki 2 each
blocknote, export, test, wysiwyg, distribution-flavor, tool-xmldoc-update-plugin 1 each

All but three sites are comments. The three string literals are two test titles ("merge objects with similar ids", "Image insertion UI can be overridden") and one assertion-failure message ("unknown block type"); a repo-wide grep confirms nothing asserts on any of them. Two of the corrections are user-visible rather than developer-only: xwiki-platform-logging's <name> and <description> read "XWiki Platform - Loggging", which is what the build log and Nexus show.

Deliberately left alone

  • The What's New blogrss.xml fixtures (3 hits). They are recorded captures of the real xwiki.org blog feed, so the improvments sits inside the captured <description> of an actual blog post — third-party data reproduced verbatim, not prose of ours. Respelling it would make the fixture a forgery of the feed it stands in for.
  • SortableTextField generaly functions exactly like TextField in managed-schema.xml. That file is Solr's stock schema with XWiki comments grafted onto it, so it is ours word by word rather than file by file: this sentence is Solr's and belongs to whoever we next sync the schema from, while the two comments prefixed XWiki: in the same file are ours and are fixed.

Three fixes the dictionary could not make

Each is the Dependencied lesson again — a single-suggestion mapping is still only a suggestion:

  • doen'tdoesn't in MacroWizard.ts. codespell maps doen to done, which would have produced done't.
  • form fielsform fields (×2) in toolbar.js, on the two lines above a comment the sweep was already rewrapping. codespell drops fiels as ambiguous (fields / files / feels); the sentence settles it.

Two comment lines that a correction pushed from exactly 120 to 121 characters were rewrapped by hand (XWikiLoader.vue, toolbar.js). Lines that were already over the limit before the correction were left as they were, as in #6079.

Verification

  • nx run-many -t lint green for the 10 affected node projects (31 of the 53 sites).
  • mvn -B -ntp verify green from xwiki-platform-search-solr-server-core-search (the module that packages the Solr schema) and from xwiki-platform-tool-xmldoc-update-plugin.
  • Every changed .xml re-parsed to confirm well-formedness.
  • The remaining files are .less / .css / webjar .js comments in modules that bind no JSHint (unlike ckeditor-plugins in [Misc] Fix misspellings in the JavaScript, CSS and XML comments of web and ckeditor #6079), so nothing in them is build-measured.

Note that pnpm run build currently fails in this checkout for a reason unrelated to this branch — the tools/tool-*config packages declare no build target, so vite.config.ts loads tool-viteconfig/src/index.ts unbuilt and Node rejects the .ts extension. It fails identically for projects this branch does not touch (platform-model-api, platform-icons, …), which is why the node verification above is the lint target rather than mvn verify.

…XML configuration

Closes the source spelling sweep started in #6079: the 53 remaining sites, over
the Vue/TypeScript packages of xwiki-platform-node, the webjar JavaScript, the
LESS/CSS, the Maven poms and the non-XAR XML (logback, Hibernate mappings, the
Solr schema).

All but three are comments. The three string literals are two Vue/Playwright
test titles and one assertion-failure message, none of them asserted on
anywhere.

Deliberately left alone:
* the What's New blogrss fixtures, which are recorded captures of the real
  xwiki.org feed, so their "improvments" belongs to the captured blog post;
* "SortableTextField generaly functions" in managed-schema.xml, which is Solr's
  own sentence in a file we sync from upstream (the two "XWiki:" comments in the
  same file are ours and are fixed).

Three hand fixes the dictionary could not make: "doen't" is "doesn't" and not
codespell's "done't", and the two "form fiels" next to the rewrapped comment in
toolbar.js are "fields" (codespell drops that word as ambiguous). Two comment
lines that a correction pushed past 120 characters were rewrapped.
@vmassol vmassol self-assigned this Aug 3, 2026
@vmassol
vmassol merged commit 46b163a into master Aug 3, 2026
2 checks passed
@vmassol
vmassol deleted the misc-typos-batch16 branch August 3, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant