[Misc] Fix misspellings in the remaining front-end sources, poms and XML configuration - #6082
Merged
Conversation
…XML configuration Closes the source spelling sweep started in #6079: the 53 remaining sites, over the Vue/TypeScript packages of xwiki-platform-node, the webjar JavaScript, the LESS/CSS, the Maven poms and the non-XAR XML (logback, Hibernate mappings, the Solr schema). All but three are comments. The three string literals are two Vue/Playwright test titles and one assertion-failure message, none of them asserted on anywhere. Deliberately left alone: * the What's New blogrss fixtures, which are recorded captures of the real xwiki.org feed, so their "improvments" belongs to the captured blog post; * "SortableTextField generaly functions" in managed-schema.xml, which is Solr's own sentence in a file we sync from upstream (the two "XWiki:" comments in the same file are ours and are fixed). Three hand fixes the dictionary could not make: "doen't" is "doesn't" and not codespell's "done't", and the two "form fiels" next to the rewrapped comment in toolbar.js are "fields" (codespell drops that word as ambiguous). Two comment lines that a correction pushed past 120 characters were rewrapped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the source spelling sweep that #6079 started: the 53 remaining sites, over 40 files and 13 top-level modules.
python3 docs/spellscan.py scan-srcnow returns zero, asscanandscan-wikialready did after #6075 and #6077.node(the Vue/TypeScript packages)searchflamingo,realtimelogging,oldcore,wikiblocknote,export,test,wysiwyg,distribution-flavor,tool-xmldoc-update-pluginAll but three sites are comments. The three string literals are two test titles (
"merge objects with similar ids","Image insertion UI can be overridden") and one assertion-failure message ("unknown block type"); a repo-wide grep confirms nothing asserts on any of them. Two of the corrections are user-visible rather than developer-only:xwiki-platform-logging's<name>and<description>read "XWiki Platform - Loggging", which is what the build log and Nexus show.Deliberately left alone
blogrss.xmlfixtures (3 hits). They are recorded captures of the real xwiki.org blog feed, so theimprovmentssits inside the captured<description>of an actual blog post — third-party data reproduced verbatim, not prose of ours. Respelling it would make the fixture a forgery of the feed it stands in for.SortableTextField generaly functions exactly like TextFieldinmanaged-schema.xml. That file is Solr's stock schema with XWiki comments grafted onto it, so it is ours word by word rather than file by file: this sentence is Solr's and belongs to whoever we next sync the schema from, while the two comments prefixedXWiki:in the same file are ours and are fixed.Three fixes the dictionary could not make
Each is the
Dependenciedlesson again — a single-suggestion mapping is still only a suggestion:doen't→doesn'tinMacroWizard.ts. codespell mapsdoentodone, which would have produceddone't.form fiels→form fields(×2) intoolbar.js, on the two lines above a comment the sweep was already rewrapping. codespell dropsfielsas ambiguous (fields / files / feels); the sentence settles it.Two comment lines that a correction pushed from exactly 120 to 121 characters were rewrapped by hand (
XWikiLoader.vue,toolbar.js). Lines that were already over the limit before the correction were left as they were, as in #6079.Verification
nx run-many -t lintgreen for the 10 affectednodeprojects (31 of the 53 sites).mvn -B -ntp verifygreen fromxwiki-platform-search-solr-server-core-search(the module that packages the Solr schema) and fromxwiki-platform-tool-xmldoc-update-plugin..xmlre-parsed to confirm well-formedness..less/.css/ webjar.jscomments in modules that bind no JSHint (unlikeckeditor-pluginsin [Misc] Fix misspellings in the JavaScript, CSS and XML comments of web and ckeditor #6079), so nothing in them is build-measured.Note that
pnpm run buildcurrently fails in this checkout for a reason unrelated to this branch — thetools/tool-*configpackages declare nobuildtarget, sovite.config.tsloadstool-viteconfig/src/index.tsunbuilt and Node rejects the.tsextension. It fails identically for projects this branch does not touch (platform-model-api,platform-icons, …), which is why the node verification above is the lint target rather thanmvn verify.