Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non_interaction: true to perf events #133

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Add non_interaction: true to perf events #133

merged 3 commits into from
Jan 15, 2025

Conversation

mehigh
Copy link
Member

@mehigh mehigh commented Jan 14, 2025 •
edited
Loading

Fixes a report that sometimes the performance events influence other GA4 metrics like AET (Active Engagement Time)

Tasks

  • Send events with the non_interaction flag set to true.

Describe the Approach

  • Changed the eventParams base to include the flag

Release Checklist

  • Review the release guidelines in the contribution documentation.
  • Update the plugin Version: header value in site-performance-tracker.php.
  • Confirm that automated tests are passing for this pull request.

@mehigh mehigh requested a review from pereirinha January 14, 2025 16:26
@mehigh mehigh changed the title Feature/non interaction Add non_interaction: true to perf events Jan 14, 2025
pereirinha
pereirinha approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@pereirinha pereirinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @mehigh

@mehigh mehigh merged commit ddb5914 into master Jan 15, 2025
1 check passed
@mehigh mehigh deleted the feature/non_interaction branch January 15, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pereirinha pereirinha pereirinha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehigh @pereirinha