Skip to content

GravityForms connector test implemented #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+2,173 −491
Open

GravityForms connector test implemented #1139

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26e0f36
GravityForms connector test implemented.
kidunot89 Jul 10, 2020
74148a3
GravityForms dependencies updated.
kidunot89 Nov 25, 2020
595d5ae
"GravityForms" installation added to .travis.yml
kidunot89 Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
.env
.idea
.env
.DS_Store
/node_modules/
/vendor/
Expand Down
24 changes: 19 additions & 5 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,23 @@
"repositories": [
{
"type": "composer",
"url": "https://wpackagist.org"
"url":"https://wpackagist.org"
},
{
"type": "package",
"package": {
"name": "gravityforms/gravityforms",
"version": "2.4.21.3",
"type": "wordpress-plugin",
"dist": {
"type": "zip",
"url": "https://www.gravityhelp.com/wp-content/plugins/gravitymanager/api.php?op=get_plugin&slug=gravityforms&key={%GRAVITYFORMS_KEY}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean that only people with GF key will be able to work on the plugin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kasparsd Yea, it is. 🤔 This might need some further tooling.

Copy link
Contributor Author

@kidunot89 kidunot89 Feb 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should skip GravityForms connector test unless the developer installs it as a dev specifically with composer. Then can probably move the whole GravityForms install process into the Travis-CI script and take it out of the composer.json.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kasparsd ☝️ What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is a good idea! We could even have another composer.json file for installing these external dependencies.

},
"require": {
"composer/installers": "^1.4",
"gotoandplay/gravityforms-composer-installer": "^2.3"
}
}
}
],
"require": {
Expand All @@ -25,14 +41,12 @@
"wpackagist-plugin/advanced-custom-fields": "5.8.12",
"wpackagist-plugin/easy-digital-downloads": "^2.9.23",
"wpackagist-plugin/user-switching": "^1.5.5",
"gravityforms/gravityforms": "2.4.21.3",
"wpsh/local": "^0.2.3"
},
"config": {
"process-timeout": 600,
"sort-packages": true,
"platform": {
"php": "5.6.20"
}
"sort-packages": true
},
"extra": {
"wordpress-install-dir": "local/public",
Expand Down
Loading