Fix/epr dictionaries #132
Merged
Fix/epr dictionaries #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGSSGene
force-pushed
the
fix/EPR-dictionaries
branch
from
d0b053c to
aeaef71
Compare
eseiler
requested changes
Mar 31, 2025
| for (uint32_t i = 0; i < result.size(); ++i) | ||
| { | ||
| result[i] = (std::rand() % 3) + 1; // no 0s allowed. produces 1, 2 or 3. | ||
| result[i] = std::rand() % 4; |
Collaborator
Author
There was a problem hiding this comment.
It was always allowed. I have no clue why that wasn't tested
Co-authored-by: Enrico Seiler <[email protected]>
eseiler
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the EPR dictionaries compute an effective alphabet size, but did not use it to map characters of the text to the narrowed range. This lead to a bugs, if enough characters where missing, such that less bits where used for storage than required.
This fixes the issues, by removing the effective alphabet size, and fixing it to the requested alphabet size via template argument.
We added a test case, which triggers the error. We added a fix that fixes the error.
Additionally, I made a little fix, to one of the other unittest, testing the full range (no reason to leave out the zero).