Fix/int vector buffer random access properties #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseiler
requested changes
Apr 3, 2025
|
|
||
| bool operator<(iterator const & it) const | ||
| { | ||
| return m_idx < it.m_idx; |
Collaborator
There was a problem hiding this comment.
I think the PR is fine as is, but I'm unsure about iterator comparisons.
What about m_ivb?
It only makes sense to ask for relations if both iterators point to the same container, no?
I think, technically, comparing two iterators referring to different containers/ranges is UB anyway.
Collaborator
Author
There was a problem hiding this comment.
mhm, I could add assert statements that check that m_ivb is non-zero and equal?
eseiler
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a categorization bug of an iterator.
int_vector_buffer::iteratorannounces itsiterator_categoryasstd::random_access_iterator_tag. This requiresto support expression like
<, >, <=, >=.This Bug is only triggered if additionally the
_GLIBCXX_DEBUGflag is set.I have a "minimal example" prepared, adjust line '82' to see my fix and/or see the compiler flags to remove the trigger : https://godbolt.org/z/W65szx7Pz
(also I fixed another minor const correctness bug in a second commit)