chore(docs): Fix quick start example - #289
Open
franz101 wants to merge 3 commits into
Open
Conversation
Author
|
@xzkostyan do you mind adding me as a maintainer or we find a way to get small improvements through? |
Owner
|
Let's start with a little PR review. Why we use pure functions instead clickhouse-dialect wrappers here? It seems that transferring It will not fix #261. For some reasons |
Author
|
I see what you mean, thanks for the feedback: this should reflect the metadata part? Can you explain the difference between clickhouse dialect wrappers? |
Author
|
In general I was assuming clickhouse 2.0 was breaking the docs |
Author
|
This seems to work for now: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current example leads to the following error with sqlalchemy > 2:
TypeError: MetaData.__init__() got an unexpected keyword argument 'bind'Maybe fixes this:
#261